fix: resolve undefined $agent_id and $job_snapshot in AIStep::executeStep()#826
Merged
fix: resolve undefined $agent_id and $job_snapshot in AIStep::executeStep()#826
Conversation
…Step() Both variables were defined in validateStepConfiguration() but used in executeStep() without being re-defined. PHP treated them as null, which silently broke per-agent tool policies (ToolPolicyResolver skipped agent filtering) and per-agent model overrides (global defaults used instead). Adds the two missing lines at the top of executeStep() to read from the engine snapshot, matching the pattern already used in validateStepConfiguration().
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$job_snapshotand$agent_idwere defined invalidateStepConfiguration()but referenced in the separate methodexecuteStep()without being re-definednull, which silently broke two things:ToolPolicyResolverreceivedagent_id = 0, skipping all agent-specific tool filteringresolveModelForAgentContext()receivednull, always returning global defaults instead of agent-specific model configdebug.logevery 5 minutes (Undefined variable $agent_idon lines 220/227)Fix
Two lines added at the top of
executeStep(), matching the exact pattern already used invalidateStepConfiguration():Impact